Skip to content

[1/7][multi-lora]: utils foundation — sample/adapter types, adapter yaml config, shared helpers, CLI flags and validation#1742

Merged
yushengsu-thu merged 2 commits into
radixark:mainfrom
mathewjhan:multi-lora/01-utils
Jul 21, 2026
Merged

[1/7][multi-lora]: utils foundation — sample/adapter types, adapter yaml config, shared helpers, CLI flags and validation#1742
yushengsu-thu merged 2 commits into
radixark:mainfrom
mathewjhan:multi-lora/01-utils

Conversation

@mathewjhan

@mathewjhan mathewjhan commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

…ml config, shared helpers, CLI flags and validation

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces multi-LoRA training support, adding configuration parsing, command-line arguments, helper utilities, and validation logic, along with corresponding unit tests. Feedback focuses on improving robustness, specifically by replacing assert statements with ValueError exceptions for argument validation to ensure compatibility with optimized Python environments. Additionally, suggestions include specifying an explicit file encoding when loading YAML configurations, using safer dictionary access methods to prevent potential KeyError or TypeError exceptions, and adding defensive checks to avoid division-by-zero errors.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread miles/rollout/generate_utils/sample_utils.py
Comment thread miles/utils/adapter_config.py
Comment thread miles/utils/adapter_config.py
Comment thread miles/utils/multi_lora.py
Comment thread miles/utils/multi_lora.py
Comment thread miles/utils/multi_lora.py
Comment thread miles/utils/multi_lora.py
Comment thread miles/utils/multi_lora.py

@yushengsu-thu yushengsu-thu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed extensively on the umbrella PR #1638 (2xH200 E2E validated); layer verified independently (imports + fast suites green on this branch's own tree).

@yushengsu-thu
yushengsu-thu merged commit ad21ac1 into radixark:main Jul 21, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants