Skip to content

[tml] Inkling model doc#1684

Merged
guapisolo merged 1 commit into
mainfrom
zhichen/inkling-doc
Jul 15, 2026
Merged

[tml] Inkling model doc#1684
guapisolo merged 1 commit into
mainfrom
zhichen/inkling-doc

Conversation

@Zhichenzzz

Copy link
Copy Markdown
Contributor

Adds the Inkling (975B) model recipe page under docs/models/thinkingmachines/, registers it in the models index and navigation. Companion to #1683.

@guapisolo guapisolo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@guapisolo
guapisolo merged commit bd49622 into main Jul 15, 2026
16 checks passed
@guapisolo
guapisolo deleted the zhichen/inkling-doc branch July 15, 2026 18:18

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces documentation for the Inkling model, a 975B multimodal MoE model from Thinking Machines. It updates the documentation index and navigation structure, and adds a comprehensive guide detailing Inkling's architecture, launch commands, and training recipes (including full-parameter, LoRA, and multimodal RL configurations). The review feedback suggests appending the user's username or UID to the temporary directories used for optimizer offloading to avoid permission conflicts on multi-user clusters.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +172 to +175
--optimizer-state-nvme-dir /tmp/opt_offload
--optimizer-state-nvme-chunk-mb 256
--offload-train-target disk
--offload-train-disk-dir /tmp/train_offload

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

When using shared temporary directories (such as /tmp) for caching or process-specific storage, it is recommended to append the user's username or UID (e.g., ${USER}) to the path. This prevents permission conflicts and directory sharing issues on multi-user clusters where multiple users might run the same launcher or script.

Suggested change
--optimizer-state-nvme-dir /tmp/opt_offload
--optimizer-state-nvme-chunk-mb 256
--offload-train-target disk
--offload-train-disk-dir /tmp/train_offload
--optimizer-state-nvme-dir /tmp/opt_offload_${USER}
--optimizer-state-nvme-chunk-mb 256
--offload-train-target disk
--offload-train-disk-dir /tmp/train_offload_${USER}
References
  1. When using shared temporary directories (such as /tmp) for caching or process-specific storage, append the user's UID (e.g. using os.getuid() or environment variables like ${USER}) to the path to avoid permission conflicts and directory sharing issues on multi-user clusters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants