ci: Sync R-CMD-check workflow from cynkratemplate - #547
Closed
krlmlr wants to merge 2 commits into
Closed
Conversation
Sync .github/workflows/R-CMD-check.yaml and .github/workflows/versions-matrix/action.R from cynkratemplate (cynkra/cynkratemplate#95). The rcc-full job now applies the generic "env" field of test matrix entries to $GITHUB_ENV itself, before the custom actions run, because composite actions cannot read the matrix context. This repo does not use the "env" field yet, so behavior is unchanged. Note that the mysql_client / mysql_server / RMARIADB_FORCE_* logic in the custom before-install and after-install actions references `${{ matrix.config.* }}`, which resolves to an empty string inside composite actions; migrating those switches to the generic "env" field would make them effective again and is left to a follow-up.
Member
Author
|
CI red on Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync
.github/workflows/R-CMD-check.yamland.github/workflows/versions-matrix/action.Rfrom cynkratemplate(cynkra/cynkratemplate#95):
the
rcc-fulljob now applies the genericenvfieldof test matrix entries to
$GITHUB_ENVitself,before the custom actions run,
because composite actions cannot read the
matrixcontext.This repo does not use the
envfield yet, so behavior is unchanged.Latent breakage found while auditing (not fixed here)
The client/server selection in the custom actions is currently inert,
because it references
${{ matrix.config.* }}inside composite actions —that resolves to an empty string
(the matrix context is unavailable there,
and today's flat matrix has no
confignesting either):custom/after-install:ankane/setup-mariadbruns on every joband
ankane/setup-mysqlnever runs,so the "MySQL server" matrix entries actually test against MariaDB 11.4.
custom/before-install(macOS):the MariaDB client is always installed, the MySQL client never,
so the "mysql_config" entry does not test
mysql_config.RMARIADB_FORCE_MARIADBCONFIG/RMARIADB_FORCE_MYSQLCONFIGare always set to the empty string.
Restoring this means migrating the switches
to the generic
envmatrix field(multi-line values are supported after the template sync),
e.g.
env = "MYSQL_SERVER=true\nRMARIADB_FORCE_MYSQLCONFIG=1",and keying the action steps on
env.*instead ofmatrix.config.*.This is left to a follow-up
because CI cannot validate it right now:
the smoke job on
mainfails before the matrix even starts —mariadb_configsegfaults on ubuntu-26.04("Install and check MariaDB client (Linux)" step, exit code 139),
which blocks
rcc-fullentirely and needs fixing first.🤖 Generated with Claude Code
https://claude.ai/code/session_0136C9bRMjBGkUrtLdkYNmAg
Generated by Claude Code