Updates README#4
Open
AndreMoukarzel wants to merge 1 commit into
Open
Conversation
- Adds alternative installation instructions to README - Removes obsolete arguments from manual execution's instructions
qxcv
reviewed
Apr 6, 2023
Owner
qxcv
left a comment
qxcv
left a comment
There was a problem hiding this comment.
Thanks for the PR André! Just made two small suggestions (LMK if these are correct).
--no-train still exists. I'm puzzled why it doesn't show up with --help.
| sudo apt install docker.io | ||
|
|
||
| cd /path/to/this/dir/for/asnets | ||
| docker build -t asnets-bionic -f asnets-bionic.dockerfile . |
Owner
There was a problem hiding this comment.
Suggested change
| docker build -t asnets-bionic -f asnets-bionic.dockerfile . | |
| docker build -t asnets-bionic . |
I updated the Dockerfile so it should be the same as the one Felipe sent through.
| ../problems/ippc08/domains/ex-blocksworld/domain.pddl \ | ||
| ../problems/ippc08/domains/ex-blocksworld/p0{1,2,3,4,5,6}*.pddl | ||
| ../problems/ippc08/domains/ex-blocksworld/p0{1,2,3,4,5,6}*.pddl \ | ||
| --num-layers 2 --hidden_size 16 |
Owner
There was a problem hiding this comment.
Suggested change
| --num-layers 2 --hidden_size 16 | |
| --num-layers 2 --hidden-size 16 |
I think it has a hyphen rather than an underscore (see https://github.com/qxcv/asnets/blob/master/asnets/asnets/scripts/run_asnets.py#L276)
| - Path do the PDDL domain and problem definitions. This are positional arguments, | ||
| and therefore should always come first! | ||
| - `--num_layers 2` controls the number of layers of the architecture. | ||
| - `--hidden_size` controls the size of each hidden latent representation of the network. |
Owner
There was a problem hiding this comment.
Suggested change
| - `--hidden_size` controls the size of each hidden latent representation of the network. | |
| - `--hidden-size` controls the size of each hidden latent representation of the network. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Updates from manual execution's instructions
I'm not 100% sure when it comes to the "Running Manually" section if I got the current arguments 100% right, so please double check!
In particular, does the
--no-trainargument still exist? It doesn't seem to show up for me when running the--helpcommand.