Skip to content

Remove unused dependencies from quickfixj-base #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrjohn merged 2 commits into from
Jun 6, 2026
Merged

Remove unused dependencies from quickfixj-base #1252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
724e970
Remove unused mockito and hamcrest dependencies, fix slf4j scope
Copilot Jun 5, 2026
a293d3f
Fix NullPointerException in FileUtilTest by correcting LICENSE path
Copilot Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions quickfixj-base/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,11 @@
<artifactId>junit-vintage-engine</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>${slf4j.version}</version>
<scope>test</scope>
</dependency>
</dependencies>

Expand Down
10 changes: 5 additions & 5 deletions quickfixj-base/src/test/java/quickfix/FileUtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,24 +35,24 @@ public class FileUtilTest {

@Test
public void testFileLocation() throws Exception {
// Assumption: current directory is QFJ project base directory
InputStream in = FileUtil.open(null, "LICENSE");
in.close();
// Tests that FileUtil.open can find a file in parent directory
InputStream in = FileUtil.open(null, "../LICENSE");
assertNotNull("File not found", in);
in.close();
}

@Test
public void testClassResourceLocation() throws Exception {
InputStream in = FileUtil.open(Message.class, "FixVersions.class");
in.close();
assertNotNull("Resource not found", in);
in.close();
}

@Test
public void testClassLoaderResourceLocation() throws Exception {
InputStream in = FileUtil.open(Message.class, "quickfix/test/acceptance/definitions/client/Normal.def");
in.close();
assertNotNull("Resource not found", in);
in.close();
}

@Test
Expand Down
Loading