Skip to content

docs(html-basics.qmd): make description consistent with link-external-filter example code#1332

Merged
cderv merged 8 commits into
quarto-dev:mainfrom
mcanouil:fix/quarto-cli10780
Jul 24, 2026
Merged

docs(html-basics.qmd): make description consistent with link-external-filter example code#1332
cderv merged 8 commits into
quarto-dev:mainfrom
mcanouil:fix/quarto-cli10780

Conversation

@mcanouil

@mcanouil mcanouil commented Sep 15, 2024

Copy link
Copy Markdown
Collaborator

The pull request fixes an inconsistency in the example description, making it consistent with the example code.

Fixes quarto-dev/quarto-cli#10780

Comment thread docs/output-formats/html-basics.qmd
@soxofaan

Copy link
Copy Markdown

also note that this example is repeated at

"name": "link-external-filter",
"description": "A regular expression that can be used to determine whether a link is an internal link. For example, \nthe following will treat links that start with http://www.quarto.org as internal links (and others\nwill be considered external):\n\n```\n^(?:http:|https:)\\/\\/www\\.quarto\\.org\\/custom\n```\n"
which also has to be addressed I think

@mcanouil mcanouil changed the title fix: make example description consistent with example code fix: make description consistent with link-external-filter example code Sep 16, 2024
@cderv
cderv requested a review from cscheid September 16, 2024 14:16
@cscheid

cscheid commented Sep 16, 2024

Copy link
Copy Markdown
Member

which also has to be addressed I think

For everyone's sake, quarto-web/docs/reference/formats/html.json is autogenerated by tools/reference.ts, which is updated by quarto run tools/reference.ts, as described on our README.

So the workflow here is we first fix the schema files (that's quarto-dev/quarto-cli#10806), then we run the command above, and do a separate PR here with the results here.

@mcanouil

Copy link
Copy Markdown
Collaborator Author

Indeed for the reference pages.
Also why this PR only changes the hardcoded example.

@mcanouil

mcanouil commented Mar 8, 2025

Copy link
Copy Markdown
Collaborator Author

FWIW, the PR I mentioned for the reference pages:

@mcanouil mcanouil changed the title fix: make description consistent with link-external-filter example code docs(html-basics.qmd): make description consistent with link-external-filter example code Jun 9, 2025

@cderv cderv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema-side fix mentioned above did land, just under a different PR than linked here. quarto-dev/quarto-cli#10806 was closed only because of a push problem on the branch, then redone from scratch as quarto-dev/quarto-cli#12481, which merged and closed #10780. The autogenerated reference page (html.json) already reflects the corrected wording on main.

So this PR's fix to the hardcoded example table is independent of that and still valid against current main. Approving — I'll merge it.

@cderv
cderv merged commit 7458929 into quarto-dev:main Jul 24, 2026
3 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusing link-external-filter example

4 participants