-
Notifications
You must be signed in to change notification settings - Fork 247
recipes-support: Add new recipe for tftp-server #1445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Pradeep-pvk
wants to merge
4
commits into
qualcomm-linux:master
Choose a base branch
from
Pradeep-pvk:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ef4e043
recipes-support: Add new recipe for tftp-server
Pradeep-pvk a08c8a0
tqftpserv: Add preference and virtual-tftp-server rprovider
Pradeep-pvk d453ccc
packagegroup-qcom: Use virtual-tftp-server
Pradeep-pvk 1dd05a4
qcom-common: Set tqftpserv as default rprovider for virtual-tftp-server
Pradeep-pvk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| SUMMARY = "Prebuilt Qualcomm tftp-server application" | ||
|
ricardosalveti marked this conversation as resolved.
|
||
| DESCRIPTION = "Prebuilt Qualcomm proprietary application for handling Remote File Systems (RFS) Requests" | ||
|
|
||
| inherit systemd | ||
|
|
||
| LICENSE = "LICENSE.qcom-2" | ||
| LIC_FILES_CHKSUM = "file://usr/share/doc/tftp-server/NO.LOGIN.BINARY.LICENSE.QTI.pdf;md5=7a5da794b857d786888bbf2b7b7529c8" | ||
|
|
||
| SRC_URI = "https://softwarecenter.qualcomm.com/nexus/generic/software/chip/component/core-technologies.qclinux.0.0/${PBT_BUILD_DATE}/prebuilt_yocto/tftp-server_15.0+really${PV}_armv8a.tar.gz" | ||
|
|
||
| PBT_BUILD_DATE = "260127" | ||
| SRC_URI[sha256sum] = "6dffae734607ce7bbde40a839b60960558df45796ed66dfd78a74ddf912a8cbd" | ||
|
|
||
| S = "${UNPACKDIR}" | ||
|
|
||
| DEPENDS += "glib-2.0 qmi-framework libcap" | ||
| RPROVIDES:${PN} += "virtual-tftp-server" | ||
| DEFAULT_PREFERENCE = "-1" | ||
|
|
||
| # This package is currently only used and tested on ARMv8 (aarch64) machines. | ||
| # Therefore, builds for other architectures are not necessary and are explicitly excluded. | ||
| COMPATIBLE_MACHINE = "^$" | ||
| COMPATIBLE_MACHINE:aarch64 = "(.*)" | ||
|
|
||
|
ricardosalveti marked this conversation as resolved.
|
||
| FILES:${PN} += "${nonarch_libdir}/tmpfiles.d/*" | ||
|
|
||
| SYSTEMD_SERVICE:${PN} += "tftp_server.service" | ||
|
|
||
| do_install() { | ||
| # Install all files from the prebuilt tarball | ||
| cp -r ${S}/* ${D}/ | ||
|
|
||
| # Move tmpfiles.d to correct location | ||
| if [ -f ${D}/etc/tmpfiles.d/tftp-server.conf ]; then | ||
| install -d ${D}${nonarch_libdir}/tmpfiles.d | ||
| cp ${D}/etc/tmpfiles.d/tftp-server.conf ${D}${nonarch_libdir}/tmpfiles.d/ | ||
| rm ${D}/etc/tmpfiles.d/tftp-server.conf | ||
| fi | ||
| } | ||
|
|
||
| pkg_postinst:${PN} () { | ||
| if [ -n "$D" ]; then | ||
| exit 0 | ||
| fi | ||
|
|
||
| if command -v systemd-tmpfiles >/dev/null 2>&1; then | ||
| systemd-tmpfiles --create ${nonarch_libdir}/tmpfiles.d/tftp-server.conf 2>/dev/null || true | ||
| fi | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be necessary with the
DEFAULT_PROVIDER, unless I misunderstand something.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works, but bitbake will issue a note asking the user to consider setting up a PREFERRED_RPROVIDER anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then do we need the
DEFAULT_PROVIDERat all if we definePREFERRED_PROVIDER?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's something to check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DEFAULT_PREFERENCEallows to de-select the version provided by a specific provider. So, I think both are not same. In this case,DEFAULT_PREFERENCEmight not be helpful.