Skip to content

feat: add launcher_config_group parameter#2

Merged
Marius1311 merged 1 commit into
mainfrom
feat/launcher-config-group
Mar 20, 2026
Merged

feat: add launcher_config_group parameter#2
Marius1311 merged 1 commit into
mainfrom
feat/launcher-config-group

Conversation

@Marius1311

Copy link
Copy Markdown
Member

Add launcher_config_group parameter to control the Hydra config group
path for launcher configs referenced by _launcher_.

Problem: _make_launcher() hardcodes hydra/launcher=<name> as a
hydra-level override. This breaks when launcher configs live at the app
level (configs/launcher/ with @package _global_), which is a valid
and common Hydra pattern.

Fix: New launcher_config_group parameter (default: "hydra/launcher")
controls where the override is placed:

  • "hydra/launcher" (default) — standard Hydra layout, override goes into hydra_overrides
  • "launcher" — app-level config group, override goes into task_overrides

Usage (in sweeper config):

hydra:
  sweeper:
    launcher_config_group: launcher  # for app-level launcher configs
    combinations:
      - {model: large, _launcher_: euler_gpu_8}
      - {model: small, _launcher_: euler_cpu}

Allow configuring the Hydra config group path for launcher configs
referenced by `_launcher_`. Defaults to `"hydra/launcher"` (standard
Hydra pattern). Set to `"launcher"` for app-level launcher configs
that use `@package _global_`.
@Marius1311 Marius1311 merged commit 283b97c into main Mar 20, 2026
6 checks passed
@codecov

codecov Bot commented Mar 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.00%. Comparing base (b40076d) to head (8a67ebc).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...c/hydra_plugins/hydra_sweeper_explicit/_sweeper.py 8.33% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
- Coverage   76.00%   70.00%   -6.00%     
==========================================
  Files           3        3              
  Lines         100      110      +10     
==========================================
+ Hits           76       77       +1     
- Misses         24       33       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Marius1311 Marius1311 deleted the feat/launcher-config-group branch March 20, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant