Skip to content

[7194][ADD] stock_barcodes, stock_picking_product_barcode_report, web_widget_numeric_step - #238

Open
nobuQuartile wants to merge 1 commit into
16.0from
7194-add-stock_barcodes
Open

[7194][ADD] stock_barcodes, stock_picking_product_barcode_report, web_widget_numeric_step#238
nobuQuartile wants to merge 1 commit into
16.0from
7194-add-stock_barcodes

Conversation

@nobuQuartile

Copy link
Copy Markdown
Contributor

QT7194

Add barcode scanning and barcode label printing for stock operations.

  • stock_barcodes (OCA/stock-logistics-barcode 16.0.2.2.4): scanner-oriented interface for pickings and inventory adjustments, reading locations, products, packagings and lots.
  • stock_picking_product_barcode_report (OCA/stock-logistics-barcode 16.0.1.0.2): wizard to print barcode labels from pickings, move lines, quants and lots.
  • web_widget_numeric_step (OCA/web 16.0.1.1.5): dependency of stock_barcodes.

All three are unmodified copies of the OCA 16.0 branches.

Note: stock_picking_product_barcode_report requires the python-barcode package (added to requirements.txt).

Assisted-by: Claude Opus 5

…_widget_numeric_step

Add barcode scanning and barcode label printing for stock operations.

- stock_barcodes: scanner-oriented interface for pickings and inventory
  adjustments, reading locations, products, packagings and lots.
- stock_picking_product_barcode_report: wizard to print barcode labels from
  pickings, move lines, quants and lots.
- web_widget_numeric_step: dependency of stock_barcodes.

Assisted-by: Claude Opus 5

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f1ff5fa578

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

<t t-if="doc.label_qty > 0">
<t
t-call="stock_picking_product_barcode_report.report_label_custom"
t-lang="doc.wizard_id.lang or doc.env.user.lang"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Read the language from the custom-label wizard

When a user selects the custom-label report and presses Print, print_labels() passes a stock.picking.print record as doc; that model has lang but no wizard_id. Evaluating this expression therefore raises a QWeb rendering error and prevents every custom-label PDF from being generated. Use the wizard's own language field here.

Useful? React with 👍 / 👎.

Comment on lines +1008 to +1011
for candidate_picking in self.candidate_picking_ids:
candidate_picking.with_context(
wiz_barcode_id=self.id, picking_id=self.picking_id.id
).action_open_picking()

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Return the action that opens the picking

When the picking button in the barcode wizard is clicked, candidate_picking.action_open_picking() constructs the form-view action, but this loop discards that result and the object method returns None. Consequently, the RPC completes without navigating away from the scanner; return the candidate's action so the picking form actually opens.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant