Remote Config v2: client core, transport and experimental API (release train)

.github/workflows/checks.yml

@@ -51,6 +51,7 @@ jobs:
           EXPECTED_URL="https://api2.qonversion.io/"
 
           MAIN_URL=$(grep 'kAPIBase = @"' Sources/Qonversion/Qonversion/Constants/QNAPIConstants/QNAPIConstants.m | sed 's/.*@"//;s/".*//')
+          REMOTE_CONFIG_V2_URL=$(grep 'kRemoteConfigV2APIBase = @"' Sources/Qonversion/Qonversion/Constants/QNAPIConstants/QNAPIConstants.m | sed 's/.*@"//;s/".*//')
           NOCODES_URL=$(grep 'baseURL = "' Sources/NoCodes/Assemblies/ServicesAssembly.swift | sed 's/.*= "//;s/".*//')
 
           FAILED=0
@@ -60,6 +61,11 @@ jobs:
             FAILED=1
           fi
 
+          if [ "$REMOTE_CONFIG_V2_URL" != "$EXPECTED_URL" ]; then
+            echo "::error::Remote Config v2 API URL mismatch: expected '$EXPECTED_URL', got '$REMOTE_CONFIG_V2_URL'"
+            FAILED=1
+          fi
+
           if [ "$NOCODES_URL" != "$EXPECTED_URL" ]; then
             echo "::error::NoCodes API URL mismatch: expected '$EXPECTED_URL', got '$NOCODES_URL'"
             FAILED=1

Framework/QonversionFramework.h

@@ -15,6 +15,9 @@
 #import <Qonversion/QONRemoteConfigurationSource.h>
 #import <Qonversion/QONSubscriptionPeriod.h>
 #import <Qonversion/QONRemoteConfig.h>
+#import <Qonversion/QONRemoteConfigValue.h>
+#import <Qonversion/QONRemoteConfigSnapshot.h>
+#import <Qonversion/QONRemoteConfigUpdate.h>
 #import <Qonversion/QONUserProperty.h>
 #import <Qonversion/QONUserProperties.h>
 #import <Qonversion/QONStoreKit2PurchaseModel.h>

Package.swift

@@ -17,6 +17,7 @@ let sources: [String] = ["Qonversion/IDFA",
                          "Qonversion/Qonversion/Core/QNKeyedArchiver",
                          "Qonversion/Qonversion/Core/QNRequestBuilder",
                          "Qonversion/Qonversion/Core/QNRequestSerializer",
+                         "Qonversion/Qonversion/Core/QONRemoteConfigV2Store",
                          "Qonversion/Qonversion/Core/QNUserDefaultsStorage",
                          "Qonversion/Qonversion/Main",
                          "Qonversion/Qonversion/Main/QNAttributionManager",
@@ -25,6 +26,7 @@ let sources: [String] = ["Qonversion/IDFA",
                          "Qonversion/Qonversion/Main/QNUserPropertiesManager",
                          "Qonversion/Qonversion/Main/QONRedemptionManager",
                          "Qonversion/Qonversion/Main/QONRemoteConfigManager",
+                         "Qonversion/Qonversion/Main/QONRemoteConfigV2Manager",
                          "Qonversion/Qonversion/Mappers",
                          "Qonversion/Qonversion/Mappers/QNErrorsMapper",
                          "Qonversion/Qonversion/Mappers/QNMapper",
@@ -42,6 +44,8 @@ let sources: [String] = ["Qonversion/IDFA",
                          "Qonversion/Qonversion/Services/QNIdentityService",
                          "Qonversion/Qonversion/Services/QNStoreKitService",
                          "Qonversion/Qonversion/Services/QONFallbackService",
+                         "Qonversion/Qonversion/Services/QONRemoteConfigFallbackStore",
+                         "Qonversion/Qonversion/Services/QONRemoteConfigV2Transport",
                          "Qonversion/Qonversion/Services/QNUserInfoService",
                          "Qonversion/Qonversion/Services/QONRemoteConfigService",
                          "Qonversion/Qonversion/Services/QONExceptionManager",

QonversionTests/APIClientTests.m

@@ -137,4 +137,27 @@ - (void)testThatClientDetectBrokenData {
   [self waitForExpectationsWithTimeout:keyQNTestTimeout handler:nil];
 }
 
+- (void)testThatServerTrustUsesSystemValidation {
+  NSURLProtectionSpace *protectionSpace = [[NSURLProtectionSpace alloc]
+    initWithHost:@"attacker.invalid"
+    port:443
+    protocol:NSURLProtectionSpaceHTTPS
+    realm:nil
+    authenticationMethod:NSURLAuthenticationMethodServerTrust];
+  id challenge = OCMClassMock([NSURLAuthenticationChallenge class]);
+  OCMStub([challenge protectionSpace]).andReturn(protectionSpace);
+
+  __block NSURLSessionAuthChallengeDisposition disposition = NSURLSessionAuthChallengeUseCredential;
+  __block NSURLCredential *credential = [NSURLCredential credentialWithUser:@"unexpected" password:@"unexpected" persistence:NSURLCredentialPersistenceNone];
+
+  [self.client URLSession:nil didReceiveChallenge:challenge completionHandler:^(NSURLSessionAuthChallengeDisposition receivedDisposition, NSURLCredential *receivedCredential) {
+    disposition = receivedDisposition;
+    credential = receivedCredential;
+  }];
+
+  XCTAssertEqual(disposition, NSURLSessionAuthChallengePerformDefaultHandling);
+  XCTAssertNil(credential);
+  [challenge stopMocking];
+}
+
 @end

QonversionTests/Managers/QNIdentityManagerTests.m

@@ -64,8 +64,6 @@ - (void)testSuccessIdentity {
   OCMStub([self.mockUserInfoService obtainUserID]).andReturn(anonUserID);
   OCMStub([self.mockIdentityService identify:userID anonUserID:anonUserID completion:OCMOCK_ANY]).andDo(testBlock);
 
-  OCMExpect([self.mockUserInfoService storeIdentity:identityID]);
-
   // when
   [self.manager identify:userID completion:^(NSString * _Nullable result, NSError * _Nullable error) {
     resultString = result;
@@ -77,8 +75,6 @@ - (void)testSuccessIdentity {
   XCTAssertEqual(randomError, resultError);
 
   OCMVerify([self.mockUserInfoService obtainUserID]);
-  OCMVerify([self.mockUserInfoService storeIdentity:identityID]);
-
   OCMVerify([self.mockIdentityService identify:userID anonUserID:anonUserID completion:OCMOCK_ANY]);
 }