feat: persist Remote Config last-known-good

QonversionTests/Managers/QNIdentityManagerTests.m

@@ -64,8 +64,6 @@ - (void)testSuccessIdentity {
   OCMStub([self.mockUserInfoService obtainUserID]).andReturn(anonUserID);
   OCMStub([self.mockIdentityService identify:userID anonUserID:anonUserID completion:OCMOCK_ANY]).andDo(testBlock);
 
-  OCMExpect([self.mockUserInfoService storeIdentity:identityID]);
-
   // when
   [self.manager identify:userID completion:^(NSString * _Nullable result, NSError * _Nullable error) {
     resultString = result;
@@ -77,8 +75,6 @@ - (void)testSuccessIdentity {
   XCTAssertEqual(randomError, resultError);
 
   OCMVerify([self.mockUserInfoService obtainUserID]);
-  OCMVerify([self.mockUserInfoService storeIdentity:identityID]);
-
   OCMVerify([self.mockIdentityService identify:userID anonUserID:anonUserID completion:OCMOCK_ANY]);
 }
 

QonversionTests/ProductCenterManagerIdentifyContractTests.m

@@ -128,11 +128,40 @@ - (void)testProcessIdentity_DifferentUid_ResetsCacheAndLaunchesWithIdentifyTrigg
   [_partialManagerMock processIdentity:identityId];
 
   // Then
-  OCMVerify([_mockClient setUserID:mergedUid]);
-  OCMVerify([_mockRemoteConfigManager userHasBeenChanged]);
+  OCMVerify([_mockRemoteConfigManager userHasBeenChangedToUserID:mergedUid]);
+  OCMReject([_mockClient setUserID:[OCMArg any]]);
   OCMVerifyAll(_partialManagerMock); // resetActualPermissionsCache + launchWithTrigger
 }
 
+- (void)testProcessIdentity_DifferentUid_RemainsUnstableUntilRemoteConfigUserTransition {
+  NSString *identityId = @"user@example.com";
+  NSString *currentUid = @"uid_initial";
+  NSString *mergedUid = @"uid_merged_999";
+
+  OCMStub([_mockUserInfoService obtainUserID]).andReturn(currentUid);
+  OCMStub([_mockIdentityManager identify:identityId completion:[OCMArg invokeBlockWithArgs:mergedUid, [NSNull null], nil]]);
+  OCMStub([_partialManagerMock resetActualPermissionsCache]);
+  OCMStub([_partialManagerMock launchWithTrigger:QONRequestTriggerIdentify completion:[OCMArg any]]).andDo(^(NSInvocation *invocation) {
+    __unsafe_unretained QONLaunchCompletionHandler completion = nil;
+    [invocation getArgument:&completion atIndex:3];
+    completion([QONLaunchResult new], nil);
+  });
+
+  _manager.launchingFinished = YES;
+  _manager.identityInProgress = YES;
+
+  __block BOOL stableDuringUserTransition = YES;
+  OCMStub([_mockRemoteConfigManager userHasBeenChangedToUserID:mergedUid]).andDo(^(NSInvocation *invocation) {
+    stableDuringUserTransition = [self.manager isUserStable];
+  });
+
+  [_partialManagerMock processIdentity:identityId];
+
+  XCTAssertFalse(stableDuringUserTransition,
+                 @"the new RC scope must replace the old scope before callers can observe a stable identity");
+  XCTAssertTrue([_manager isUserStable]);
+}
+
 /*
  * Same-uid case: the user "identifies" with what is effectively the same
  * Qonversion uid (e.g. host app calls identify again with no real switch).
@@ -173,6 +202,7 @@ - (void)testProcessIdentity_IdentityError_DoesNotResetCacheOrRelaunch {
   OCMReject([_partialManagerMock resetActualPermissionsCache]);
   OCMReject([_partialManagerMock launchWithTrigger:QONRequestTriggerIdentify completion:[OCMArg any]]);
   OCMReject([_mockRemoteConfigManager userHasBeenChanged]);
+  OCMReject([_mockRemoteConfigManager userHasBeenChangedToUserID:[OCMArg any]]);
   OCMReject([_mockClient setUserID:[OCMArg any]]);
 
   // When