Fixed spmd typecheck for qwen35 and kimi27 - #4388
Open
jinsooihm wants to merge 1 commit into
Open
Conversation
jinsooihm
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
September 1, 2026 00:58
tianyu-l
approved these changes
Sep 1, 2026
Contributor
should add TP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some changes in #4121 that made the spmd typecheck fail.
The integration tests do not test for spmd_typecheck with TP > 1 for qwen35 and kimi27, so this was not caught.
Test plan
spmd_typesstrict typechecking: 1 training step passed.spmd_typesstrict typechecking: 1 training step passed using a test-only AdamW configuration with the TP-incompatible QK-clip hook disabled.scripts/loss_compare.py: compared parent4ab7596c0againstc302e9fb1on Qwen3.5 TP=2 for 10 deterministic steps. Full-precision loss andgrad_normwere bitwise identical at every step.ufmt,flake8,pydoclint, andgit diff --checkpassed.