[ROCm][CI] Re-enable ROCm CI & make CI changes as per new CI design - #4361
Draft
akashveramd wants to merge 5 commits into
Draft
[ROCm][CI] Re-enable ROCm CI & make CI changes as per new CI design#4361akashveramd wants to merge 5 commits into
akashveramd wants to merge 5 commits into
Conversation
Renames integration_test_features_rocm.yaml to integration_test_rocm.yaml and re-enables the ROCm matrix in set-matrix.yaml, which was temporarily disabled while ROCm jobs were red. Key changes: - Adds ciflow/rocm/* tag trigger to integration_test_rocm.yaml so ROCm jobs can be triggered on demand from PRs via tag, in addition to the existing push-to-main trigger. - Restores the ROCm matrix entry in set-matrix.yaml (runner: linux.rocm.gpu.ecosystem.mi350.8, ROCm 10.0, rocm10.0 nightly index). - Fixes the matrix selection logic so that when gpu-arch=rocm is explicitly requested (e.g. from a ciflow/rocm tag run via workflow_call), FULL_MATRIX is used rather than falling through to CUDA-only. Previously IS_MAIN_PUSH/IS_SCHEDULE were the only conditions that included ROCm, which meant tag-triggered workflow_call runs produced an empty matrix. Test Plan: Push a ciflow/rocm/* tag to trigger the ROCm workflow and verify jobs land on linux.rocm.gpu.ecosystem.mi350.8 with ROCm 10.0. Co-authored-by: AI assistant Co-authored-by: Cursor <cursoragent@cursor.com>
Adds an AMD GPU (ROCm) row to the Test status table pointing to the integration_test_rocm.yaml workflow. Co-authored-by: AI assistant Co-authored-by: Cursor <cursoragent@cursor.com>
Registers ciflow/rocm with pytorch-probot so it can push the ciflow/rocm tag to trigger ROCm CI jobs on demand. Co-authored-by: AI assistant Co-authored-by: Cursor <cursoragent@cursor.com>
akashveramd
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
August 27, 2026 23:07
meta-cla
Bot
added
the
CLA Signed
|
Warning: Unknown label
Please add the new label to .github/pytorch-probot.yml |
Renames the workflow from "Integration Tests - Features (ROCm)" to "Integration Tests (ROCm)" and the job from "features" to "rocm", since the workflow runs both features and models test suites. This fixes the confusing "features / 8 GPU Integration ..." prefix shown for both jobs in the PR checks UI. Co-authored-by: AI assistant Co-authored-by: Cursor <cursoragent@cursor.com>
akashveramd
marked this pull request as draft
August 27, 2026 23:22
akashveramd
marked this pull request as ready for review
August 28, 2026 19:25
akashveramd
marked this pull request as draft
August 28, 2026 19:36
Contributor
|
Seems the bot have an error: #4361 (comment) |
Collaborator
Author
@wwwjn: The bot warning was triggered before commit 232d3f1 added ciflow/rocm to .github/pytorch-probot.yml. That commit is now included in this PR, so the label is properly registered, and the warning won't recur once this is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR covers most of the features that were part of this PR (unmerged & closed) #4039.
This PR also makes following CI changes-
ciflow/8gpulabel as a trigger for the CUDA-specific workflows.ciflow/rocmlabel as a trigger for the ROCm-specific workflows.-- This label can be added manually by PR developers wanting to test on ROCm.
-- This label will also be automatically added by the pytorch bot for any PRs that mention ROCm in the title/description.