Skip to content

fix stack overread on truncated range in cpulist parse_entry #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
soma0212 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix stack overread on truncated range in cpulist parse_entry #431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/linux/cpulist.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,15 @@ inline static bool parse_entry(
}

const char* number_start = number_end + 1;
if (number_start == entry_end) {
/* Nothing follows the '-' separator; ignore the entry */
cpuinfo_log_warning(
"missing end of range in the cpu list entry \"%.*s\": entry is ignored",
(int)entry_length,
entry_start);
return false;
}

number_end = parse_number(number_start, entry_end, &last_cpu);
if (number_end == number_start) {
/* Failed to parse the second number; ignore the entry */
Expand Down