Skip to content

add db cleanup for PyPy #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattip wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add db cleanup for PyPy #472

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dc18f9
add db cleanup for PyPy
mattip May 10, 2026
dedaa04
do session resetting differently, from review
mattip May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyperformance/data-files/benchmarks/bm_sqlalchemy_declarative/run_benchmark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ def bench_sqlalchemy(loops, npeople):
# drop rows created by the previous benchmark
session.query(Person).delete(synchronize_session=False)
session.query(Address).delete(synchronize_session=False)
session.expunge_all()
Copy link
Copy Markdown

@zzzeek zzzeek May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be a more realistic test to use a new session for each loop here

like

for loops in range(loops):
    with DBSession() as session:
         # everything else here

cheaper than calling expunge_all() and makes it clear where we're starting the operation


# Run the benchmark once
t0 = pyperf.perf_counter()
Expand Down
Loading