Skip to content

gh-148483: Use Py_GCC_ATTRIBUTE(unused) for stop_tracing label #148481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 10 commits into from
Apr 13, 2026
Merged

gh-148483: Use Py_GCC_ATTRIBUTE(unused) for stop_tracing label #148481

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1bd649e
Use Py_GCC_ATTRIBUTE(unused) for stop_tracing label
clin1234 Apr 13, 2026
d629c82
Actually regenerate the generated files to include attribute
clin1234 Apr 13, 2026
25b0445
Wrap attribyte with _Py_TAIL_CALL_INTERP macro check
clin1234 Apr 13, 2026
30924f4
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 13, 2026
67d3971
Space
clin1234 Apr 13, 2026
ff75471
Regen
clin1234 Apr 13, 2026
cda01d6
Update conditional compilation for tail-call labels
clin1234 Apr 13, 2026
4949861
Update conditional compilation for tail call interpreter
clin1234 Apr 13, 2026
aaba401
Modify conditional compilation for tail call interp
clin1234 Apr 13, 2026
b082a45
Update Misc/NEWS.d/next/Build/2026-04-13-02-36-13.gh-issue-148483.gLe…
clin1234 Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
*.cover
*.iml
*.o
*.o.tmp
*.lto
*.a
*.so
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Build/2026-04-13-02-36-13.gh-issue-148483.gLe1h8.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Use Py_GCC_ATTRIBUTE(unused) for stop_tracing label
Comment thread
clin1234 marked this conversation as resolved.
Outdated
3 changes: 3 additions & 0 deletions Modules/_testinternalcapi/test_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions Python/generated_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions Tools/cases_generator/tier1_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,10 @@ def generate_tier1_labels(
emitter.emit("\n")
# Emit tail-callable labels as function defintions
for name, label in analysis.labels.items():
if name == 'stop_tracing':
emitter.emit("#if _Py_TAIL_CALL_INTERP\n")
Copy link
Copy Markdown
Member

@Fidget-Spinner Fidget-Spinner Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used in the JIT. So you need

#if _Py_TAIL_CALL_INTERP && !defined(_Py_TIER2)

emitter.emit("Py_GCC_ATTRIBUTE((unused))\n")
emitter.emit("#endif\n")
emitter.emit(f"LABEL({name})\n")
storage = Storage(Stack(), [], [], 0, False)
if label.spilled:
Expand Down
Loading