Skip to content

Fix naturaldelta truncating years instead of rounding #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArmaanjeetSandhu wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −0
Open

Fix naturaldelta truncating years instead of rounding #295

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f6b58c
Fix naturaldelta truncating years instead of rounding
ArmaanjeetSandhu Feb 17, 2026
7a7a5b4
Update tests/test_time.py
ArmaanjeetSandhu Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/humanize/time.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,7 @@ def naturaldelta(

return _ngettext("1 year, %d day", "1 year, %d days", days) % days

years = round(delta.days / 365)
return _ngettext("%d year", "%d years", years).replace("%d", "%s") % intcomma(years)


Expand Down
1 change: 1 addition & 0 deletions tests/test_time.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ def test_naturaldelta_nomonths(test_input: dt.timedelta, expected: str) -> None:
(dt.timedelta(days=9), "9 days"),
(dt.timedelta(days=365), "a year"),
(dt.timedelta(days=365 * 1_141), "1,141 years"),
(dt.timedelta(days=1058), "3 years"),
Comment thread
ArmaanjeetSandhu marked this conversation as resolved.
Outdated
("NaN", "NaN"), # Returns non-numbers unchanged.
# largest possible timedelta
(dt.timedelta(days=999_999_999), "2,739,726 years"),
Expand Down
Loading