Repository navigation
chore: collect changelog entries with towncrier - #768
Merged
Merged
Conversation
tobixen
added a commit
that referenced
this pull request
Oct 14, 2026
get_davclient()'s test-server fallback called claim_server() on every server, but the caldav.testing and config-file servers that a pip-installed caldav uses have none, so every server was skipped. A server that failed to start also kept its claim until the process exited. Without fcntl (Windows), embedded and external servers now start unlocked instead of failing; docker servers still need fcntl. Prompt: dismiss the false positive and merge 776. Leave 768 for a while [the false positive: a CodeQL "file is not always closed" warning on a test fixture; 776 is #776 - its merge review found the bugs fixed here; 768 is #768, unrelated] Followup-Prompt: do the needful [fix the bug the merge review found - the fallback skipping every server of a pip-installed caldav - plus the claim left held after a failed start and the missing fcntl on Windows] Assisted-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Parallel pull requests keep conflicting in CHANGELOG.md. After 3.5.0, each change adds a fragment to changes/ and towncrier build merges them in at release time. A custom template keeps the existing entry style. The hand-written 3.5.0 section stays below the towncrier marker; RELEASE-HOWTO notes that open branches must move their entries into fragments. Prompt: set up caldav with towncrier, the CHANGELOG management system Followup-Prompt: We're preparing for 3.5.0 now. Things are frozen, only really important bugfixes will go in now. When 3.5.0 is released, everything should go through towncrier. The changelog as it is should go through normal QA and get stamped with 3.5.0. Hence, towncrier should not touch anything before 3.5.0 is out, but 3.5.0 should already be set up, process of using it in CONTRIBUTING.md, etc Followup-Prompt: The open PRs that goes (sic) in after release will have to be rewritten to support towncrier Followup-Prompt: PR#768 should be rebased and merged [= #768, this pull request, onto master after the 3.5.0 release] Assisted-By: Claude Opus 5.5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
A CHANGELOG polished in a back-and-forth with an AI assistant and committed straight to master skips the usual QA, and leaves master with a string of commits carrying prompts nobody needs. Prompt: Do a QA on my sentence, commit it directly to master, rebase when #768 is merged, and I'll push it manually [= the sentence added to the list of release mistakes; #768 is the towncrier PR] Prompts (comments made inline in the document while reviewing it): > (on the review of #768) Please piggyback my latest commit to the RELEASE-HOWTO.md into the same PR Assisted-By: Claude Opus 5.5 (Claude Code) Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
tobixen
force-pushed
the
chore/towncrier
branch
from
October 15, 2026 11:17
9dfca43 to
ded8ef9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit message:
Parallel pull requests keep conflicting in CHANGELOG.md. After 3.5.0,
each change adds a fragment to changes/ and towncrier build merges
them in at release time. A custom template keeps the existing entry
style. The 3.5.0 entries stay in the Unreleased section, stamped by
hand, as RELEASE-HOWTO now says.
Prompt: set up caldav with towncrier, the CHANGELOG management system
Followup-Prompt: We're preparing for 3.5.0 now. Things are frozen, only really important bugfixes will go in now. When 3.5.0 is released, everything should go through towncrier. The changelog as it is should go through normal QA and get stamped with 3.5.0. Hence, towncrier should not touch anything before 3.5.0 is out, but 3.5.0 should already be set up, process of using it in CONTRIBUTING.md, etc
Followup-Prompt: The open PRs that goes (sic) in after release will have to be rewritten to support towncrier
Assisted-By: Claude Opus 5.5 noreply@anthropic.com
Meant to be part of 3.5.0, so that fragments are used from the first change after it. Whoever stamps the 3.5.0 CHANGELOG must keep the
<!-- towncrier release notes start -->marker line.🤖 Generated with Claude Code