Skip to content

fix: keep all expanded occurrences in split search - #723

Merged
tobixen merged 2 commits into
masterfrom
issue-722-expand-dedup
Oct 5, 2026
Merged

tobixen merged 2 commits into
masterfrom
issue-722-expand-dedup

Conversation

@tobixen

@tobixen tobixen commented Oct 1, 2026

Copy link
Copy Markdown
Member

Fixes #722

Commit message:

fix: keep all expanded occurrences in split search

search(start, end, expand=True) without a component type returned only
the first occurrence of a recurring event since v3.3.0.  The search is
split into one query per component type, and the merged results were
deduplicated by URL - which every expanded occurrence of an event
shares.  Deduplicate on URL plus RECURRENCE-ID instead, so overlapping
queries still collapse while distinct occurrences survive.

https://github.com/python-caldav/caldav/issues/722

Prompt: Look into issue #722 [https://github.com/python-caldav/caldav/issues/722]
Followup-Prompt: [write a failing test, fix it, update the CHANGELOG]

Assisted-By: Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>

🤖 Generated with Claude Code

@tobixen
tobixen force-pushed the issue-722-expand-dedup branch from 04a0f5c to cf0b808 Compare October 1, 2026 22:44
tobixen and others added 2 commits October 5, 2026 17:16
search(start, end, expand=True) without a component type returned only
the first occurrence of a recurring event since v3.3.0.  The search is
split into one query per component type, and the merged results were
deduplicated by URL - which every expanded occurrence of an event
shares.  Deduplicate on URL plus RECURRENCE-ID instead, so overlapping
queries still collapse while distinct occurrences survive.

#722

Prompt: Look into issue #722 [#722]
Followup-Prompt: [write a failing test, fix it, update the CHANGELOG]

Assisted-By: Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Experiences from a few users, see
#722 and
jawah/niquests#475.

Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
@tobixen
tobixen force-pushed the issue-722-expand-dedup branch from cf0b808 to 739fad8 Compare October 5, 2026 15:19
@tobixen
tobixen merged commit 4517862 into master Oct 5, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v3.3.0 broke expand=True

1 participant