fix: tolerate an empty calendar-user-address-set - #716
Merged
Merged
Conversation
Compatibility hints adjusted to match master version of xandikos. Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
get_vcal_address() indexed the address list blindly, so a server that advertises the property and returns it empty produced `IndexError: list index out of range` out of a public API - and out of add_organizer() and add_attendee(), which go through it. RFC 6638 section 2.4.1 covers this: a user with no well-defined calendar user address is identified by the URI of his principal resource, and that is what the sync and async variants now fall back to. An absent property still raises NotFoundError, which the same section defines as not enabled for scheduling. Xandikos 0.4.7 is such a server, and gets the new scheduling.calendar-user-address-set.populated feature graded unsupported rather than a weakened assert in testAddOrganizer. The same fallback goes into change_attendee_status(), which resolves an attendee through the address set too: without it the library invited a principal to an event it could then not update. Prompt: I've checked out master and adjusted the compatibility hints so that the compatibility check passes with the master version of xandikos. `pytest -k xandikos` still gives failures. Please investigate. (sic) (four IndexError test failures pasted) Followup-Prompt: [fix this with a] new feature flag for the xandikos problem Assisted-By: Claude Opus 5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
caldav/config.py optionally imports tests.test_servers.registry to auto-start a test server when run from a source checkout, falling back gracefully via ImportError otherwise. deptry's isolated CI install doesn't ship tests/, so it flagged the import as missing, which was also breaking this PR's deptry check independently of its own change. Prompt: Add fix as another commit onto PR 716, after all the purpose of PR 716 is to get the tests green again Assisted-By: Claude Sonnet 5 <noreply@anthropic.com>
Both tutorials create a "Test tasklist" calendar restricted to VTODO, and left it behind on the test server. Xandikos 0.4.7 honours supported-calendar-component-set, so the leftover poisoned the next doc test: get_calendar() handed out the tasklist, and add_event() got a 403 Forbidden. Deleting it mirrors what the "Creating Calendars" section already does, and keeps the tutorial's claim that the test server has exactly one calendar true. Prompt: [fix broken tests from #716 - tests/test_docs.py::DocTests::test_tutorial] Assisted-By: Claude Opus 5 <noreply@anthropic.com> Reviewed-By: Tobias Brox <tobias@redpill-linpro.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xandikos served us an empty calendar-user-address-set, the library responded by raising
IndexError: list index out of range. RFC 6638 §2.4.1 has the URI of the principal resource stand in for a user with no well-defined calendar user address, so that fallback has now been made on the client side. The same fallback goes intochange_attendee_status(). An absent property still raisesNotFoundError.The new compatibility feature
scheduling.calendar-user-address-set.populatedhas been set to unsupported for Xandikos.schedulingandcreate-calenar.with-supported-component-typeshas been set to supported, as Xandikos 0.4.7 has added support.🤖 Code (mostly) generated with Claude Code
Companion PR: python-caldav/caldav-server-tester#16 — the probe that measures the new feature.