Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users of the library are trying to push icalendar Event objects into the caldav library, and it fails. The CalDAV protocol demands that each "calendar object resource" is wrapped in an icalendar Calendar, but one of the objectives with this library is that users should not need to know many details about the CalDAV protocol. Hence this should be possible.
Solves #546
Partial fix for #541
Caveat: the fix has two code paths, one for the (yet to be published) icalendar>=7 and another for icalendar<7. However, the test code will only run on icalendar>=7 - meaning that this fix has not been verified for icalendar 6.