Skip to content

Fix MovieLens dataset incompatibility with SentenceTransformers =5.x #10668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akihironitta merged 7 commits into from
Apr 18, 2026
+6 −2
Merged

Fix MovieLens dataset incompatibility with SentenceTransformers =5.x #10668

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1f2a193
Fix MovieLens dataset incompatibility with SentenceTransformers =5.x
drivanov Apr 13, 2026
d7ff162
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 13, 2026
c073bc4
Updating CHANGELOG.md
drivanov Apr 14, 2026
b988ba9
Merge branch 'movie_lens' of https://github.com/drivanov/pytorch_geom…
drivanov Apr 14, 2026
717089c
Merge branch 'master' into movie_lens
drivanov Apr 16, 2026
28b3f54
Update CHANGELOG.md
akihironitta Apr 18, 2026
e5d24d2
Update torch_geometric/datasets/movie_lens.py
akihironitta Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).

### Fixed

- Fix MovieLens dataset incompatibility with `sentence-transformers>=5.0.0` ([#10668](https://github.com/pyg-team/pytorch_geometric/pull/10668)
- Removed an unnecessary device synchronization in `torch_geometric.utils.softmax` ([#10499](https://github.com/pyg-team/pytorch_geometric/pull/10499))
- Fixed loading of legacy HuggingFace BERT checkpoints ([#10631](https://github.com/pyg-team/pytorch_geometric/pull/10631))
- Fixed `return_attention_weights: bool` being not respected in `GATConv` and `GATv2Conv` ([#10596](https://github.com/pyg-team/pytorch_geometric/pull/10596))
Expand Down
3 changes: 2 additions & 1 deletion torch_geometric/datasets/movie_lens.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ def process(self) -> None:

model = SentenceTransformer(self.model_name)
with torch.no_grad():
emb = model.encode(df['title'].values, show_progress_bar=True,
emb = model.encode(df['title'].astype(str).tolist(),
show_progress_bar=True,
convert_to_tensor=True).cpu()
Comment thread
akihironitta marked this conversation as resolved.
Outdated

data['movie'].x = torch.cat([emb, genres], dim=-1)
Expand Down
Loading