-
Notifications
You must be signed in to change notification settings - Fork 0
Render team member avatars from GitHub profile images #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,9 @@ | |
|
|
||
| {% for member in site.data.team %} | ||
| <div class="member-card"> | ||
| <div class="member-avatar">{{ member.avatar }}</div> | ||
| <div class="member-avatar"> | ||
| <img src="https://github.com/{{ member.github }}.png" alt="{{ member.name }} avatar" loading="lazy" width="48" height="48"> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. width and height should go into CSS.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually, they are in there. They can be deleted.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The URL redirects. That's not a good idea. |
||
| </div> | ||
| <div class="member-info"> | ||
| <div class="member-header"> | ||
| {% include heading.html title=member.name class="member-name" %} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That can stay in case we get a 404 for the image.