Skip to content

Fix lint issues from #22 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kandersolar merged 1 commit into from
Feb 6, 2025
Merged

Fix lint issues from #22 #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions pvfactors/geometry/pvrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from pvfactors.config import COLOR_DIC
from pvfactors.geometry.base import \
BaseSide, _coords_from_center_tilt_length, PVSegment
from shapely.geometry import GeometryCollection, LineString
from shapely.geometry import LineString
from pvfactors.geometry.timeseries import \
TsShadeCollection, TsLineCoords, TsSurface
from pvlib.tools import cosd, sind
Expand Down Expand Up @@ -709,10 +709,6 @@ def length(self):
"""Length of the PV row."""
return self.front.length + self.back.length

@property
def boundary(self):
return self._linestring.boundary

def intersects(self, line):
"""Check if the PV row intersects with a line.

Expand Down
2 changes: 1 addition & 1 deletion pvfactors/viewfactors/vfmethods.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ def vf_pvrow_to_pvrow(self, ts_pvrows, tilted_to_left, vf_matrix):
surf_i.coords, surf_j.coords, length_i)
vf_i_to_j = np.where(tilted_to_left, vf_i_to_j, 0.)
vf_j_to_i = np.divide(
vf_i_to_j * length_i , length_j,
vf_i_to_j * length_i, length_j,
where=length_j > DISTANCE_TOLERANCE,
out=np.zeros_like(length_j))
vf_matrix[i, j, :] = vf_i_to_j
Expand Down