docs: s-expression artifact format — honest cost analysis, recommend Option A#162
Open
docs: s-expression artifact format — honest cost analysis, recommend Option A#162
Conversation
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: aef153e | Previous: aa706fc | Ratio |
|---|---|---|---|
link_graph_build/10000 |
37599747 ns/iter (± 2642609) |
27530692 ns/iter (± 3638629) |
1.37 |
validate/10000 |
15082659 ns/iter (± 1425852) |
10896266 ns/iter (± 1631891) |
1.38 |
query/10000 |
146593 ns/iter (± 676) |
90574 ns/iter (± 529) |
1.62 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
aef153e to
9b4f497
Compare
Concrete, cost-estimated design doc covering four scope options (A: export- only, B: read-only import, C: full bidirectional, D: replace YAML) with verified LoC-based effort estimates drawn from reading the existing rivet-core and rivet-cli sources. Recommendation: Option A gated on YAML fuzzer results. Option C is 40-60 person-days up front plus ~20%/yr dual-path maintenance and is not justified on current evidence. Refs: #128 Refs: DD-048
9b4f497 to
422f847
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this ships
`docs/design/sexpr-artifact-format.md` — honest cost analysis for adding s-expression as an artifact format alongside YAML.
TL;DR
Recommended path: Option A (`rivet convert --to sexpr`, one-way export-only), gated on the YAML fuzzer (#158 in this batch).
Total for recommended: ~5 (Option A) + ~2 (fuzzer) ≈ 7 days.
Why not further
Test plan
Doc only.
🤖 Generated with Claude Code