Draft
Conversation
This workaround had been justified by a compatibility issue in Chromium, present in Electron versions less than 13.5.0 or less than 14.0.0. The flag shouldn't be needed anymore, now that Pulsar is on Electron 30. It'll be good to turn sandboxing back on, for whatever good it does, and also to be back on a default setting again. The less workarounds, the better.
DeeDeeG
changed the title
--no-sandbox flag usage
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This workaround had been justified by a compatibility issue in Chromium, present in Electron versions less than 13.5.0 or less than 14.0.0.
The flag shouldn't be needed anymore, now that Pulsar is on Electron 30. It'll be good to turn sandboxing back on, for whatever good it does, and also to be back on a default setting again. The less workarounds, the better.
One instance (possibly the most important instance, at a glance?) of this flag had already been removed from
script/electron-builder.jsin #1367, but it doesn't hurt to be thorough. Shouldn't, at least.Context
See: atom/atom#23036