Skip to content

Add a fingerprint to ManifestSignature#2326

Open
dralley wants to merge 1 commit intopulp:mainfrom
dralley:fingerprint
Open

Add a fingerprint to ManifestSignature#2326
dralley wants to merge 1 commit intopulp:mainfrom
dralley:fingerprint

Conversation

@dralley
Copy link
Copy Markdown
Contributor

@dralley dralley commented Apr 15, 2026

closes #2261

📜 Checklist

  • Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
  • A changelog entry or entries has been added for any significant changes
  • Follows the Pulp policy on AI Usage
  • (For new features) - User documentation and test coverage has been added

See: Pull Request Walkthrough

Comment thread pulp_container/app/serializers.py Outdated
digest = serializers.CharField(help_text="sha256 digest of the signature blob")
type = serializers.CharField(help_text="Container signature type, e.g. 'atomic'")
key_id = serializers.CharField(help_text="Signing key ID")
fingerprint = serializers.CharField(help_text="Signing key fingerprint")
Copy link
Copy Markdown
Contributor Author

@dralley dralley Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use PgpKeyFingerprintField here, if you're comfortable with that

https://github.com/pulp/pulp_rpm/blob/main/pulp_rpm/app/serializers/repository.py#L91-L96

It's a bit different though

@dralley
Copy link
Copy Markdown
Contributor Author

dralley commented Apr 15, 2026

Ugh, looks like my pulpcore commit broke something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Store a fingerprint on ManifestSignature

1 participant