Open
Conversation
mdellweg
reviewed
Apr 14, 2026
Comment on lines
+104
to
+107
| assert ( | ||
| "Proxy Authentication Required" in exc_info.value.task.error["description"] | ||
| or "Proxy authentication failed" in exc_info.value.task.error["description"] | ||
| ) |
Member
There was a problem hiding this comment.
Can we test for the new way also?
Suggested change
| assert ( | |
| "Proxy Authentication Required" in exc_info.value.task.error["description"] | |
| or "Proxy authentication failed" in exc_info.value.task.error["description"] | |
| ) | |
| assert ( | |
| "[PLP0010]" in exc_info.value.task.error["description"] | |
| or "Proxy Authentication Required" in exc_info.value.task.error["description"] | |
| or "Proxy authentication failed" in exc_info.value.task.error["description"] | |
| ) |
| exc_info.value.task.error["description"] | ||
| == "Could not determine API version for: http://i-am-an-invalid-url.com/invalid/" | ||
| ) | ||
| if has_pulp_plugin("core", min="3.102"): |
Member
There was a problem hiding this comment.
It feels like this is not the complete set of versions requirement.
But also, this is an exception updated here. Would that not lead to "[PLPAN07]" completely independent of the pulpcore version at play?
| Raised when a remote is missing a required URL for synchronization. | ||
| """ | ||
|
|
||
| error_code = "PLPAN02" |
Member
There was a problem hiding this comment.
A reminder for all of us: There's a high chance we want to change that naming schema in about a week before it sediments into stone.
aKlimau
force-pushed
the
add-pulp-exceptions
branch
from
82d8d71 to
f2c4f63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: Claude Sonnet 4.5 noreply@anthropic.com
📜 Checklist
See: Pull Request Walkthrough