fix: handle empty string for optional URL env vars#22
Merged
86667 merged 2 commits intoip_verificationfrom Apr 8, 2026
Merged
Conversation
When HG_PHOENIXD_API_URL is unset, docker-compose passes an empty string which envy tries to parse as a URL, causing "relative URL without a base" error on startup. Add a custom deserializer that treats empty strings as None. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on:
Summary
HG_PHOENIXD_API_URLis unset, docker-compose passes an empty string (${HG_PHOENIXD_API_URL:-}), whichenvytries to parse as a URL, crashing the container withrelative URL without a base: ""Option<Url>that treats empty strings asNoneTest plan
docker compose up --buildwithout settingHG_PHOENIXD_API_URL— container should start without errorscurl -X POST http://0.0.0.0:8080/ip_verification— should return a signup code🤖 Generated with Claude Code