Skip to content

feat(toroika-three-text): Add a lang option to preloadFont. #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lojjic merged 1 commit into from
Sep 3, 2025
+4 −2
Merged

feat(toroika-three-text): Add a lang option to preloadFont. #368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/troika-three-text/src/TextBuilder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,11 +391,13 @@ function initContextLossHandling(atlas) {
* possible glyphs, e.g. `["t", "h", "th"]` to get the "t" and "h" glyphs plus the "th" ligature.
* @param {number} options.sdfGlyphSize - The size at which to prerender the SDF textures for the
* specified `characters`.
* @param {string} options.lang - The language code of this text; can be used for explicitly selecting
* certain CJK fonts.
* @param {function} callback - A function that will be called when the preloading is complete.
*/
function preloadFont({font, characters, sdfGlyphSize}, callback) {
function preloadFont({font, characters, sdfGlyphSize, lang}, callback) {
let text = Array.isArray(characters) ? characters.join('\n') : '' + characters
getTextRenderInfo({ font, sdfGlyphSize, text }, callback)
getTextRenderInfo({ font, sdfGlyphSize, text, lang }, callback)
}


Expand Down