feat: add not-equals field selector support in CustomQuotas documentation#99
Merged
sandert-k8s merged 2 commits intoJul 6, 2026
Merged
Conversation
…tion Signed-off-by: sandert-k8s <sandert98@gmail.com>
Signed-off-by: sandert-k8s <sandert98@gmail.com>
✅ Deploy Preview for docs-projectcapsule ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the documentation to describe and demonstrate support for a not-equals (!=) field selector syntax in CustomQuotas/GlobalCustomQuotas, including updated examples and an additional reference-table field.
Changes:
- Add a new “Not-Equals” section describing
!=field selector behavior and recommended usage patterns. - Update existing selector examples to use
!=syntax (notably for excluding completed Pods from CPU/memory accounting). - Add
clusterScopedto two API reference tables.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| content/en/docs/resource-management/customquotas/_index.md | Adds != field selector documentation and updates selector examples accordingly. |
| content/en/docs/reference.md | Adds clusterScoped as a documented field in two reference tables. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+248
to
+250
| > **Recommended for CPU and memory resources** | ||
| > | ||
| > Kubernetes built-in [`ResourceQuota`](https://kubernetes.io/docs/concepts/policy/resource-quotas/#compute-resource-quota) excludes terminal Pods (those in `Succeeded`, `Failed`, or `Unknown` phase) from CPU and memory accounting by default, because those Pods no longer hold resources on the kubelet. When defining CustomQuotas or GlobalCustomQuotas for CPU or memory resources, it is strongly recommended to use `!=` field selectors to exclude terminal Pods and match this behavior. |
Comment on lines
699
to
+701
| #### Calculate total requested CPU across tenant namespaces (Running Pods) | ||
|
|
||
| This pattern mirrors the default behavior of Kubernetes `ResourceQuota`, which excludes terminal Pods from CPU and memory accounting. |
| | :---- | :---- | :----------- | :-------- | | ||
| | **status** | enum | status of the condition, one of True, False, Unknown.<br/>*Enum*: True, False, Unknown<br/> | true | | ||
| | **type** | string | type of condition in CamelCase or in foo.example.com/CamelCase. | true | | ||
| | **clusterScoped** | boolean | Indicates whether the referenced resource is cluster-scoped. | false | |
oliverbaehler
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.