Clone ring from the head of the ring repository into third_party#2681
Merged
jul-sh merged 4 commits intoproject-oak:mainfrom Apr 6, 2022
Merged
Clone ring from the head of the ring repository into third_party#2681jul-sh merged 4 commits intoproject-oak:mainfrom
jul-sh merged 4 commits intoproject-oak:mainfrom
Conversation
conradgrobler
approved these changes
Apr 5, 2022
andrisaar
approved these changes
Apr 5, 2022
jul-sh
force-pushed
the
ring-clone
branch
2 times, most recently
from
d4da1d6 to
135cc4b
Compare
ipetr0v
approved these changes
Apr 6, 2022
added 3 commits
April 6, 2022 14:37
Ring has been cloned cloned into third_party, using commit 32b2c6c39ef459aad47f476fe9139b8d57532ab1 from https://github.com/briansmith/ring. This is done so that we will be able to later port our own patch onto it, specifically UEFI compatibility from: briansmith/ring#1406.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ring has been cloned cloned into third_party, using commit 32b2c6c39ef459aad47f476fe9139b8d57532ab1 from https://github.com/briansmith/ring. This is done so that we will be able to later port our own patch onto it, specifically UEFI compatibility from: briansmith/ring#1406.
Note that this does not yet build or use the ring clone. In order to build it in our repo some patches are needed. The reason this is a separate PR is purely that we squash PR commits. For provenance it would be nice to have a commit in the main branch that contains the unaltered clone, allowing us to record all subsequent changes in version history.