Skip to content

feat: reject unknown fields from API requests (fixes #478) #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mithilesh1909 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: reject unknown fields from API requests (fixes #478) #791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion router/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ impl PartialEq for AdapterParameters {
impl Eq for AdapterParameters {}

#[derive(Clone, Debug, Deserialize, ToSchema)]
#[serde(deny_unknown_fields)]
pub(crate) struct GenerateParameters {
#[serde(default)]
#[schema(
Expand Down Expand Up @@ -329,6 +330,7 @@ fn default_parameters() -> GenerateParameters {
}

#[derive(Clone, Debug, Deserialize, ToSchema)]
#[serde(deny_unknown_fields)]
pub(crate) struct GenerateRequest {
#[schema(example = "My name is Olivier and I")]
pub inputs: String,
Expand All @@ -347,6 +349,7 @@ fn default_true() -> bool {
}

#[derive(Clone, Debug, Deserialize, ToSchema)]
#[serde(deny_unknown_fields)]
pub(crate) struct CompatGenerateRequest {
#[schema(example = "My name is Olivier and I")]
pub inputs: String,
Expand Down Expand Up @@ -374,6 +377,7 @@ impl From<CompatGenerateRequest> for GenerateRequest {
}

#[derive(Clone, Debug, Deserialize, ToSchema)]
#[serde(deny_unknown_fields)]
pub(crate) struct TokenizeRequest {
#[schema(example = "My name is Olivier and I")]
pub inputs: String,
Expand Down Expand Up @@ -665,6 +669,7 @@ impl From<Message> for TextMessage {
}

#[derive(Clone, Debug, Deserialize, ToSchema)]
#[serde(deny_unknown_fields)]
struct ChatCompletionRequest {
model: String,
messages: Vec<Message>,
Expand Down Expand Up @@ -969,6 +974,7 @@ pub(crate) struct Tool {
}

#[derive(Clone, Debug, Deserialize, ToSchema)]
#[serde(deny_unknown_fields)]
struct CompletionRequest {
model: String,
prompt: String,
Expand Down Expand Up @@ -1156,6 +1162,7 @@ impl Default for EmbedParameters {
}

#[derive(Clone, Debug, Deserialize, ToSchema)]
#[serde(deny_unknown_fields)]
struct EmbedRequest {
inputs: String,
#[serde(default)]
Expand Down Expand Up @@ -1211,16 +1218,19 @@ struct CompatEmbedding {
}

#[derive(Clone, Debug, Deserialize, ToSchema)]
#[serde(deny_unknown_fields)]
struct ClassifyRequest {
inputs: String,
}

#[derive(Clone, Debug, Deserialize, ToSchema)]
#[serde(deny_unknown_fields)]
struct BatchClassifyRequest {
inputs: Vec<String>,
}

#[derive(Clone, Debug, Deserialize, ToSchema)]
#[serde(deny_unknown_fields)]
struct BatchEmbedRequest {
inputs: Vec<String>,
#[serde(default)]
Expand Down Expand Up @@ -1591,4 +1601,4 @@ mod tests {
}
Tokenizer::from_file("tokenizer.json").unwrap()
}
}
}