Improve dark mode support for editor and preview#1413
Open
TeaTinyTool wants to merge 1 commit into
Open
Conversation
Make the ACE editor and file preview follow the current TinyFileManager theme. Dark mode now uses a matching ACE theme and a separate Highlight.js style for previews, while light mode keeps the existing behavior. Plain text previews without Highlight.js also receive dark mode styling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This improves dark mode support for the ACE editor and the file preview.
Problem
The TinyFileManager dark mode is currently not fully reflected in editor and preview views:
TextMatetheme.$highlightjs_style.Changes
TextMateas the ACE theme in TinyFileManager light mode.Twilightas the ACE theme in TinyFileManager dark mode.$highlightjs_style_darksetting next to$highlightjs_style.$highlightjs_stylein light mode.$highlightjs_style_darkin dark mode.vs2015.Expected behavior