Bugfix/db silent bugs - #166
Merged
Xarlos89 merged 4 commits intoJul 4, 2026
Merged
Conversation
…sed within DO 33470 block, at best this fails silently if POSTGRES_DB=eos because docker creates the database anyway beforehand, and errors out if db is renamed to something else
… number within the container, but in docker-compose.yml the container port number is inflexibly hardcoded to 5432. Add a new envvar to specify port number used by host system in case 5432 conflicts with host's psql
Xarlos89
requested changes
Jun 25, 2026
Xarlos89
left a comment
Xarlos89
left a comment
Collaborator
There was a problem hiding this comment.
We should also update the readme because it tells users to change the POSTGRES_PORT, and they should instead change the POSTGRES_PORT_HOST.
…, fix readme, remove inline comments in .env
Contributor
Author
|
Xarlos89
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your PR
Some fixes to small bugs in the docker workflow that only come up when changing the psql database name/other settings
Describe your changes
Fixed
Issue link
Closes #165
Checklist
pre-commitover your PR?master?master?