Reformat sources with Dart 3.10 - #462
Open
simolus3 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PowerSync Dart SDK supports Dart 3.10 or newer (as it uses build hooks and depends on versions 3.x of
package:sqlite3, which both require that Dart version).However, it declares a minimum Dart version of 3.6 in its pubspec. To be able to use newer language features and APIs, this raises that to 3.10. This also changes the behavior of the Dart formatter, which automatically adds trailing commas to methods now. I ran
dart formatin thepowersyncpackage.The only non-whitespace changes in this PR are in
test/sync/utils.dart: IncheckpointCompleteandbucketDescription, we now use a null shorthand (replacingif (subscriptions != null) 'subscriptions': subscriptionswith'subscriptions': ?subscriptions). This fixes analysis warnings.