Web: Use navigator locks - #368
Draft
simolus3 wants to merge 5 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent multiple databases in the same process attempting to sync at the same time, we guard the sync client with a
Muteximplementation fromkotlinx.coroutines. This implementation is implemented in Kotlin and purely local to the process creating it.On the web, we also want to guard against multiple tabs attempting to sync at the same time. We should ideally use a shared worker for that like we do on our other SDKs, but we definitely don't want two tabs to sync independently at the same time.
This adds the internal
PowerSyncMutexinterface providing a subset ofMutexthat can be implemented with navigator locks. The implementation for native platforms and the JVM is unchanged. For the web, this uses navigator locks to guard the sync client. This also moves thewithAbortSignalutility from:coreto:common, as it's helpful for the mutex implementation.AI use: Implementation manual, reviewed with Claude Code.