Skip to content

Remove builder style - #82

Merged
rich-iannone merged 3 commits into
posit-dev:mainfrom
has2k1:remove-builder-style
Apr 13, 2026
Merged

rich-iannone merged 3 commits into
posit-dev:mainfrom
has2k1:remove-builder-style

Conversation

@has2k1

@has2k1 has2k1 commented Apr 2, 2026

Copy link
Copy Markdown
Collaborator

The renderer has no style-specific logic, making BuilderPkgdown,
BuilderSinglePage, and the _registry/init_subclass dispatch
mechanism redundant.

Depends on #81

The renderer has no style-specific logic, making BuilderPkgdown,
BuilderSinglePage, and the _registry/__init_subclass__ dispatch
mechanism redundant.
@has2k1
has2k1 force-pushed the remove-builder-style branch from bf2e5d8 to 81b24dd Compare April 2, 2026 06:46
has2k1 and others added 2 commits April 2, 2026 16:32
Previous commit undid a bundling of these errors but left the test
unchanged.
Conflict resolution in core.py: kept main's pragma comments and
the 'Configure the API reference' comment, while adopting the PR's
removal of 'style' from api_ref_config (Builder no longer uses it).
@rich-iannone

Copy link
Copy Markdown
Member

@has2k1 thanks for this cleanup! Will review and then merge.

@rich-iannone rich-iannone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rich-iannone
rich-iannone merged commit 45a4cee into posit-dev:main Apr 13, 2026
7 checks passed
@has2k1
has2k1 deleted the remove-builder-style branch July 15, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants