Repository navigation
refactor: start each build with independent state - #486
Merged
Merged
Conversation
Start each build with fresh state for results shared by its steps. On repeated builds of the same `GreatDocs` instance, an earlier build no longer suppresses API reference generation, supplies a stale MCP outcome to the reference switcher, or leaves an old homepage path in the user guide sidebar. The first build on an instance behaves as before, and the instance's caches still last as long as the instance.
📚 Preview this PR's docs locallyFetch the just-built site and open it in your browser: # this exact build
great-docs preview --run 41094422426
# or always the latest build for this PR
great-docs preview --pr 486Auth & tips
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A second
build()on the sameGreatDocsinstance now starts from a clean state, like the first.Results shared between build steps lived on the instance as flags that were never reset, and most were read through
getattrdefaults that type checkers cannot see. So a later build inherited an earlier one's outcome. If one build found no API reference, every later build on that instance skipped it. The reference switcher could see an earlier build's MCP outcome. The user-guide sidebar could keep a previous build's blended homepage path. Each build now holds these values in a state object that it creates at the start and passes to the steps that read them. The first build on an instance behaves as before.