Repository navigation
feat: add light/dark theme pairs and cursor colors for Termshow - #436
Merged
Merged
Conversation
📚 Preview this PR's docs locallyFetch the just-built site and open it in your browser: # this exact build
great-docs preview --run 40398532927
# or always the latest build for this PR
great-docs preview --pr 436Auth & tips
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds light/dark theme pairs to termshow recordings:
theme: autouses the built-ingithub-light/github-darkpair, andtheme: {light, dark}lets authors choose their own pair, with each side a theme name or an inline mapping. The manifest stays at version 2 and gains an optionaldarkmember that holds the dark theme's colors and rows in parallel tolines, so a pair adds a second set of colors rather than a second set of frames (SVG files and posters use the light side).The player draws the side that matches the page's color mode (
data-bs-theme, the Quarto classes, orprefers-color-scheme) and redraws when the mode changes. Themes also gain an optionalcursorcolor, and the player's light-mode CSS, whosebody[data-bs-theme]selectors never matched on Great Docs sites, now works through a class the player sets itself.The schemas, the Terminal Recordings guide (with a live
theme: autodemo), the format spec, and the tests (including node parity tests for dark-side drawing and mode detection) are now updated to match.