Skip to content

feat: add light/dark theme pairs and cursor colors for Termshow - #436

Merged
rich-iannone merged 15 commits into
mainfrom
feat-termshow-theme-pairs
Oct 26, 2026
Merged

rich-iannone merged 15 commits into
mainfrom
feat-termshow-theme-pairs

Conversation

@rich-iannone

Copy link
Copy Markdown
Member

This PR adds light/dark theme pairs to termshow recordings: theme: auto uses the built-in github-light/github-dark pair, and theme: {light, dark} lets authors choose their own pair, with each side a theme name or an inline mapping. The manifest stays at version 2 and gains an optional dark member that holds the dark theme's colors and rows in parallel to lines, so a pair adds a second set of colors rather than a second set of frames (SVG files and posters use the light side).

The player draws the side that matches the page's color mode (data-bs-theme, the Quarto classes, or prefers-color-scheme) and redraws when the mode changes. Themes also gain an optional cursor color, and the player's light-mode CSS, whose body[data-bs-theme] selectors never matched on Great Docs sites, now works through a class the player sets itself.

The schemas, the Terminal Recordings guide (with a live theme: auto demo), the format spec, and the tests (including node parity tests for dark-side drawing and mode detection) are now updated to match.

@github-actions

Copy link
Copy Markdown

📚 Preview this PR's docs locally

Fetch the just-built site and open it in your browser:

# this exact build
great-docs preview --run 40398532927

# or always the latest build for this PR
great-docs preview --pr 436
Auth & tips
  • Requires great-docs: pip install great-docs (or run via pipx/uvx).
  • Auth: run gh auth login then add --use-gh, or set GITHUB_TOKEN (needs Actions: read).
  • Jump to a page: add --path reference/index.html.
  • Latest vs exact: --pr <n> grabs the newest build; --run <id> pins this one.
  • Re-download: --refresh ignores the local cache.

@rich-iannone
rich-iannone merged commit 628f972 into main Oct 26, 2026
8 checks passed
@rich-iannone
rich-iannone deleted the feat-termshow-theme-pairs branch October 26, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant