Repository navigation
fix: publish a section's directory once - #420
Merged
Merged
Conversation
When a section's `dir` was also the conventional user guide or custom pages directory, the build published the same pages under two URLs. Conventional discovery now leaves a section's directory to the section. An explicit `user_guide` or `custom_pages` naming a section's directory is rejected before the build starts.
📚 Preview this PR's docs locallyFetch the just-built site and open it in your browser: # this exact build
great-docs preview --run 39947318508
# or always the latest build for this PR
great-docs preview --pr 420Auth & tips
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stops a site from publishing the same pages twice when a section claims the
user_guide/orcustom/directory that great-docs also discovers by convention. The section now wins. Whenuser_guide:orcustom_pages:names a section's directory explicitly, the build stops with an error instead of publishing duplicate URLs.