Repository navigation
Remove dead code from the post-render script - #366
Merged
Merged
Conversation
Delete the source-link helper and the dataclass Attributes table rewrite, neither of which could ever run, along with the sidecar files they loaded. Delete a second pass that fixed the metadata script path, which an earlier pass already handled, and the start-up directory listings. Catch specific exceptions instead of `Exception`. A programming error in the SEO, i18n, scale-to-fit or alternate-link passes now fails the build instead of printing a line and carrying on. Rendered output of four gauntlet packages is unchanged.
has2k1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes code from great_docs/assets/post-render.py that can never run or does work that an earlier step already does, and makes its error handling stricter.