Repository navigation
fix: improve Mermaid figure layout when a caption is present - #364
Merged
Merged
Conversation
📚 Preview this PR's docs locallyFetch the just-built site and open it in your browser: # this exact build
great-docs preview --run 37478012777
# or always the latest build for this PR
great-docs preview --pr 364Auth & tips
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where a Mermaid diagram with a
fig-caprendered very small, with its caption to the right of the SVG instead of underneath.The fix makes the figure now stack things vertically (
flex-direction: column; align-items: stretch), so the caption sits under the diagram. Captions are centered to match the centered diagram. Small diagrams keep their natural size, where Mermaid's inlinemax-widthon the SVG is left alone. Uncaptioned diagrams look the same as before.I added a new GDG site (
gdtest_mermaid) with three diagrams: a wide one with a labeled caption, a small one with an unlabeled caption, and one with no caption.Here's how figures now render with Mermaid in Great Docs:
Fixes: #361