Frame the input_signature probe's parameter as a multi-element set (wala/ML#638)#469
Merged
Conversation
…robe (wala#638). Follow-up to the merged #467. The decorated `f` passes its parameter to `g`; what `g` receives depends on the execution mode a static analysis cannot determine: traced the signature governs ((None,) int32), eager it is the call-site argument ((3,) int32). So the sound type of `g`'s parameter is the set {(None,), (3,)}. The fixture now documents both modes without a `run_functions_eagerly` call (the eager element is the argument at the call site), and the test pins the current argument-derived (3,) with the sound set spelled out in the TODO toward wala#638. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01USFp76oHfj2u3wUSCo87cg
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #469 +/- ##
=========================================
Coverage 72.34% 72.34%
Complexity 3083 3083
=========================================
Files 287 287
Lines 21615 21615
Branches 3625 3625
=========================================
Hits 15637 15637
Misses 4506 4506
Partials 1472 1472 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the merged #467. A
@tf.function(input_signature=[(None,) int32])-decoratedfpasses its parameter tog(the FUT). Whatgreceives depends on the execution mode, which a static analysis cannot determine:greceives(None,)int32;run_functions_eagerly: the signature is ignored,greceives the call-site argument's(3,)int32.So the sound type of
g's parameter is the set{(None,), (3,)}int32 -- a plain union, no provenance categories (which is also why the retracted wala#634's tagged-set diagnosis was wrong, not just its justification).The fixture documents both modes with no
run_functions_eagerlycall (the eager element is just the argument at the call site; Ariadne doesn't and shouldn't analyze the global/dynamic eager mode). The test pins the current argument-derived(3,)and spells out the sound set in the TODO toward wala#638, which is reframed accordingly.🤖 Generated with Claude Code