Change BookShelves.Shelf to Return (*Shelf, bool) and Remove StructIsEmpty - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes the
BookShelves.Shelflookup API from a zero-value sentinel to an explicit(*Shelf, bool)return, deletes the reflection-basedStructIsEmptyhelper, and updates every caller acrosscmd/bookandinternal/model. Also fixes the delete completed view and scrubs the legacypolybookname fromCONTRIBUTING.md.What's new
BookShelves.Shelf(name)now returns(*Shelf, bool), matching the existingShelf.Collectionnil-on-miss pattern.StructIsEmpty- deletes the reflection helper and its test; callers now rely on the boolean ornilchecks.markRootScreenpassesnilforget/edit/delete, andGetMarkFormshows/hides the mark picker by action, preventing the nil-mark panic in interactive flows.ResultViewnow renders the removed mark instead of the whole collection.polybookwithbookinCONTRIBUTING.md.Behavior changes / guardrails
(nil, false)instead of&Shelf{}; all production callers have been updated to check the boolean.book mark get/edit/removeand hidden foradd/list.markRootScreenno longer materializes an emptybook.Mark; it passes the provided pointer through.Testing
TestBookShelvesShelfcovering found and missing shelf lookups.cmd/book/actions_test.goto use atestShelfhelper that asserts theokreturn.make checkruns fmt, vet, lint, and tests; all green.