Repository navigation
Simplify sorting dependencies with Pydantic query models - #16160
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
frankie567
marked this pull request as ready for review
October 30, 2026 15:07
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Bounded refactor replacing dynamic makefun signature generation with a Pydantic query model, preserving the sorting query parameter shape, defaults, and enum validation.
View guided diff | Turn on auto-fix | Re-trigger cubic
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorting parameters used a dynamic function generation pattern to be able to inject a query parameter with a dynamic type generated from an enum.
Now that FastAPI allows to use Pydantic models as query parameters, we can generate a Pydantic model dynamically instead, removing the need of a complete dynamic function builder, which feels more natural and less magic.