Repository navigation
feat(products): add is_current filter to list products - #16156
Draft
strandhvilliam wants to merge 1 commit into
Draft
strandhvilliam wants to merge 1 commit into
strandhvilliam wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 4 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Adds an optional is_current query filter to the public GET /v1/products/ (2027-01) endpoint, letting clients list previous product versions while keeping the default current-only behavior. This changes a public API contract, so human review is required.
View guided diff | Turn on auto-fix | Re-trigger cubic
strandhvilliam
force-pushed
the
villiam/product-is-current-filter
branch
from
October 30, 2026 14:46
be8772f to
dea726a
Compare
strandhvilliam
changed the base branch from
main
to
villiam/product-version-label
October 30, 2026 14:46
Contributor
|
strandhvilliam
force-pushed
the
villiam/product-is-current-filter
branch
from
October 30, 2026 15:05
9df5c5f to
97fc6a4
Compare
Previous product versions were only reachable by id. The filter still defaults to current versions, and false returns only previous ones.
strandhvilliam
force-pushed
the
villiam/product-is-current-filter
branch
from
October 30, 2026 15:08
97fc6a4 to
bc6b6a0
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
is_currentfilter toGET /v1/products/(2027-01 only), so previous product versions can be listed.I guess it technically would be cleaner if
is_currentis omitted ment = all products would be returned, no matter if current or not. But don't want to break existing logic and you probably expect the current ones to be returned anyway, even if it is an implicit query filterSo with this PR instead it would mean:
id)true: current versions onlyfalse: previous versions only