Fix single Pick values containing commas - #7601
Open
faisalahammad wants to merge 2 commits into
Open
Conversation
faisalahammad
requested review from
JoryHogeveen and
sc0ttkclark
as code owners
August 10, 2026 14:06
Contributor
Author
|
AI disclosure: this PR was written with Claude Opus 5 assistance, reviewed and tested by me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Single-value Pick dropdown options containing commas were split during save. This caused valid custom-simple values such as
$3,500 - $9,999to be rejected and saved as empty.The save path now keeps scalar values intact for single-select fields and keeps comma splitting for multi-select fields. A regression test covers custom-simple dropdown values containing commas across supported storage and Pod types.
Related GitHub issue(s)
Fixes #7374
Testing instructions
Single Select.Drop Down.$3,500 - $9,999.Automated regression test:
The focused test could not run in this environment because Composer dependencies could not be installed.
php -lpassed for changed PHP files andgit diff --checkpassed. Composer installation is blocked by existing dependency constraints involving WPGraphQL security advisories, Faker on PHP 8.5, and Polylang minimum stability.Screenshots / screencast
Not applicable. No UI code changed.
Changelog text for these changes
Bug: Single Pick dropdown values containing commas now save correctly. #7374 (@faisalahammad)
PR checklist