Skip to content

Fix single Pick values containing commas - #7601

Open
faisalahammad wants to merge 2 commits into
pods-framework:release/3.4.0from
faisalahammad:fix/7374-single-dropdown-comma-value
Open

Fix single Pick values containing commas#7601
faisalahammad wants to merge 2 commits into
pods-framework:release/3.4.0from
faisalahammad:fix/7374-single-dropdown-comma-value

Conversation

@faisalahammad

Copy link
Copy Markdown
Contributor

Description

Single-value Pick dropdown options containing commas were split during save. This caused valid custom-simple values such as $3,500 - $9,999 to be rejected and saved as empty.

The save path now keeps scalar values intact for single-select fields and keeps comma splitting for multi-select fields. A regression test covers custom-simple dropdown values containing commas across supported storage and Pod types.

Related GitHub issue(s)

Fixes #7374

Testing instructions

  1. Create a Pick field with Selection Type set to Single Select.
  2. Set format to Drop Down.
  3. Add custom options with comma-containing values, such as $3,500 - $9,999.
  4. Create or edit a Pod item.
  5. Select the comma-containing option and save.
  6. Reload the item.
  7. Confirm the selected option remains selected and its value and label are unchanged.

Automated regression test:

vendor/bin/codecept run wpunit Pods/Bug/Bug7374Test -vvv

The focused test could not run in this environment because Composer dependencies could not be installed. php -l passed for changed PHP files and git diff --check passed. Composer installation is blocked by existing dependency constraints involving WPGraphQL security advisories, Faker on PHP 8.5, and Polylang minimum stability.

Screenshots / screencast

Not applicable. No UI code changed.

Changelog text for these changes

Bug: Single Pick dropdown values containing commas now save correctly. #7374 (@faisalahammad)

PR checklist

@faisalahammad
faisalahammad changed the base branch from main to release/3.4.0 August 18, 2026 11:03
@faisalahammad

Copy link
Copy Markdown
Contributor Author

AI disclosure: this PR was written with Claude Opus 5 assistance, reviewed and tested by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Single Value Drop Down Select field will not save if there is a comma in the values

1 participant