Skip to content

test(Thread): deflake testTrySleep and prevent SEGFAULT on failure #5316 #5329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matejk merged 1 commit into from
Apr 21, 2026
+35 −18
Merged

test(Thread): deflake testTrySleep and prevent SEGFAULT on failure #5316 #5329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 35 additions & 18 deletions Foundation/testsuite/src/ThreadTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,25 +423,42 @@ void ThreadTest::testTrySleep()
assertTrue (!thread.isRunning());
assertTrue (r.counter() == 0);
thread.start(r);
assertTrue (thread.isRunning());
assertTrue (r.counter() == 0);
assertTrue (r.isSleepy());
Thread::sleep(100);
assertTrue (r.counter() == 0);
assertTrue (r.isSleepy());
thread.wakeUp(); Thread::sleep(10);
assertTrue (r.counter() == 1);
assertTrue (r.isSleepy());
Thread::sleep(100);
assertTrue (r.counter() == 1);
thread.wakeUp(); Thread::sleep(10);
assertTrue (r.counter() == 2);
assertTrue (r.isSleepy());
Thread::sleep(200);
assertTrue (r.counter() == 3);
assertTrue (!r.isSleepy());
assertTrue (!thread.isRunning());
auto waitForCounter = [&](int expected)
{
for (int i = 0; i < 500 && r.counter() < expected; ++i)
Thread::sleep(10);
};
try
{
assertTrue (thread.isRunning());
assertTrue (r.counter() == 0);
assertTrue (r.isSleepy());
Thread::sleep(100);
assertTrue (r.counter() == 0);
assertTrue (r.isSleepy());
thread.wakeUp();
waitForCounter(1);
assertTrue (r.counter() == 1);
assertTrue (r.isSleepy());
Thread::sleep(100);
assertTrue (r.counter() == 1);
thread.wakeUp();
waitForCounter(2);
assertTrue (r.counter() == 2);
assertTrue (r.isSleepy());
waitForCounter(3);
assertTrue (r.counter() == 3);
assertTrue (!r.isSleepy());
assertTrue (!thread.isRunning());
}
catch (...)
{
thread.wakeUp();
thread.join();
throw;
}
thread.wakeUp();
assertTrue (thread.tryJoin(5000));
assertTrue (!thread.isRunning());
}

Expand Down
Loading