Skip to content

fix: Add MINGW compiler macro for MSYS2 Clang64 environment #5209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
feihongmeilian wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Add MINGW compiler macro for MSYS2 Clang64 environment #5209

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
247647b
fix: Add MINGW compiler macro for MSYS2 Clang64 environment
feihongmeilian Feb 15, 2026
4db265c
Merge branch 'pocoproject:main' into main
feihongmeilian Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Foundation/include/Poco/Platform.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,9 @@
#if __has_include(<cxxabi.h>)
#define POCO_HAVE_CXXABI_H
#endif
#if defined (__MINGW32__) || defined (__MINGW64__)
Copy link
Copy Markdown
Contributor

@matejk matejk Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This addition is correct and valuable. Currently, MSYS2 Clang64 gets POCO_COMPILER_CLANG but not POCO_COMPILER_MINGW, which means MinGW-specific workarounds (e.g. avoiding __try/__except SEH) do not trigger. This is the right fix for the core issue described in this PR.

#define POCO_COMPILER_MINGW
#endif
#elif defined(_MSC_VER)
#define POCO_COMPILER_MSVC
#elif defined (__GNUC__)
Expand Down